enter replicasets from deployments #3001
Conversation
Signed-off-by: Rudrakh Panigrahi <[email protected]>
There was a problem hiding this comment.
@rudrakhp Nice!
I don't think i can review the code, so i will keep it for @derailed 😄 .
IMO, you're right that the replicaset makes more sense on enter press than the pod list. But, we should keep the pod behavior in a different shortcut (like P key if not used) and not removing it. I'm sure it's being used.
Side note, in any case we need to update the docs on the new logic
|
I think the |
There was a problem hiding this comment.
@rudrakhp Thank you for this PR! Tho technically this is correct, I don't think we should alter the current behavior as this was a conscious decision to get to the pertinent information quickly aka show me the latest incarnation of the pods associated with this deployment.
That said, I think it makes sense to nav dp->rs so users can see the various versions at stake.
derailed
added
enhancement
Fixes #2951
Today on entering a deployment, pods associated with it are listed. Changed behaviour to list replicasets instead. Entering replicaset will list the related pods.
Ran
make build && ./execs/k9son a test cluster to validate behaviour.